fix: update building warning.#1223
Conversation
Reviewer's GuideThis PR systematically suppresses compiler warnings by marking unused parameters and variables with Q_UNUSED or [[maybe_unused]], commenting out or wrapping unused code, introducing explicit casts to resolve type mismatches, and adjusting build flags to relax strict warning settings. Class diagram for updated model classes with Q_UNUSED usageclassDiagram
class RoleCombineModel {
+RoleCombineModel(QAbstractItemModel* major, QAbstractItemModel* minor, QObject* parent)
+rowCount(const QModelIndex &parent) const
+columnCount(const QModelIndex &parent) const
+index(int row, int column, const QModelIndex &parent) const
+parent(const QModelIndex &child) const
+roleNames() const
// Many signal/slot lambdas now use Q_UNUSED for unused parameters
}
class DockGlobalElementModel {
+DockGlobalElementModel(QAbstractItemModel *appsModel, DockPanel *panel, QObject *parent)
+rowCount(const QModelIndex &parent) const
+columnCount(const QModelIndex &parent) const
+index(int row, int column, const QModelIndex &parent) const
+parent(const QModelIndex &child) const
// Many signal/slot lambdas now use Q_UNUSED for unused parameters
}
class DockItemModel {
+rowCount(const QModelIndex &parent) const
+columnCount(const QModelIndex &parent) const
+index(int row, int column, const QModelIndex &parent) const
+parent(const QModelIndex &child) const
// Q_UNUSED added for parent/child parameters
}
class DockGroupModel {
+requestOpenUrls(const QModelIndex &index, const QList<QUrl> &urls) const
+requestUpdateWindowGeometry(const QModelIndex &index, const QRect &geometry, QObject *delegate) const
// Q_UNUSED added for unused parameters
}
class NotifyModel {
+rowCount(const QModelIndex &parent) const
+sort(int column, Qt::SortOrder order)
// Q_UNUSED added for parent, column, order parameters
}
class NotifyStagingModel {
+rowCount(const QModelIndex &parent) const
// Q_UNUSED added for parent parameter
}
class AbstractWindowMonitor {
+rowCount(const QModelIndex &parent) const
// Q_UNUSED added for parent parameter
}
Class diagram for constructor member initialization order fixesclassDiagram
class AMAppItem {
+AMAppItem(const QDBusObjectPath &path, QObject *parent)
// Now initializes Application before AppItem
}
class AppGroupManager {
+AppGroupManager(AMAppItemModel * referenceModel, QObject *parent)
// m_config initialization order fixed
}
class TreeLandDockPreviewContext {
+TreeLandDockPreviewContext(struct ::treeland_dock_preview_context_v1 *context)
// m_hideTimer initialization order fixed
}
class WaylandDockHelper {
+WaylandDockHelper(DockPanel *panel)
// m_panel initialization order fixed
}
class X11WindowPreviewContainer {
+X11WindowPreviewContainer(X11WindowMonitor* monitor, QWidget *parent)
// m_direction initialization order fixed
}
Class diagram for updated copy constructorsclassDiagram
class DAppletData {
+DAppletData(const DAppletData &other)
// Now calls QObject() in copy constructor
}
class DPluginMetaData {
+DPluginMetaData(const DPluginMetaData &other)
// Now calls QObject() in copy constructor
}
Class diagram for updated signal/slot lambdas with Q_UNUSEDclassDiagram
class RoleGroupModel {
+setSourceModel(QAbstractItemModel *model)
// rowsInserted, rowsRemoved lambdas now use Q_UNUSED for parent
}
class AMAppItemModel {
+AMAppItemModel(QObject *parent)
// InterfacesRemoved lambda now uses Q_UNUSED for interfaces
}
class AppearanceApplet {
+AppearanceApplet(QObject *parent)
// serviceRegistered lambda now uses Q_UNUSED for service
}
class AMApplet {
+onInterfacesRemoved(const QDBusObjectPath &objPath, const QStringList &interfaces)
// Q_UNUSED for interfaces
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
c5e4fb5 to
ac4149e
Compare
as title. Log:
ac4149e to
595082f
Compare
deepin pr auto review根据提供的代码 diff,我来对代码进行审查,并提出改进意见:
总体而言,代码质量较好,大部分遵循了良好的 C++ 实践。主要需要关注的是实现被标记为 TODO 的功能,以及确保所有未使用的参数都有适当的 Q_UNUSED 宏和注释说明。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
as title.
Log:
Summary by Sourcery
Silence compiler warnings and update build configuration
Enhancements:
Build:
Tests: